-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add language model provider extensions #44186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete this entire since_v0.7.0 directory.
| ) -> result<bool, string>; | ||
|
|
||
| /// Get a stored credential for this provider. | ||
| import llm-get-credential: func(provider-id: string) -> option<string>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to move all of the importable functions on the guest into a separate module (either llm-provider.wit or a different one), as this makes it easier to version between extension versions.
Anything that is top-level in extension.wit needs to be redefined for every single extension API version, even if there are no changes. But if they live in their own WIT module then we can share them, so long as there are no changes.
assets/settings/default.json
Outdated
| "auto_install_extensions": { | ||
| "html": true | ||
| "anthropic": true, | ||
| "copilot_chat": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want all of our extension IDs to be kebab-cased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I decided to land these in another PR, so reverting this for now anyway!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, can delete since_v0_7_0.rs.
6e76953 to
8b1ce75
Compare
| _task: Arc<Task<Result<(), gpui_tokio::JoinError>>>, | ||
| } | ||
|
|
||
| impl Drop for WasmExtension { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming, is this removal intentional?
Release Notes: