Skip to content

Conversation

@rtfeldman
Copy link
Contributor

Release Notes:

  • N/A or Added/Fixed/Improved ...

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 4, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this entire since_v0.7.0 directory.

) -> result<bool, string>;

/// Get a stored credential for this provider.
import llm-get-credential: func(provider-id: string) -> option<string>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move all of the importable functions on the guest into a separate module (either llm-provider.wit or a different one), as this makes it easier to version between extension versions.

Anything that is top-level in extension.wit needs to be redefined for every single extension API version, even if there are no changes. But if they live in their own WIT module then we can share them, so long as there are no changes.

"auto_install_extensions": {
"html": true
"anthropic": true,
"copilot_chat": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want all of our extension IDs to be kebab-cased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I decided to land these in another PR, so reverting this for now anyway!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, can delete since_v0_7_0.rs.

@rtfeldman rtfeldman force-pushed the provider-extensions branch from 6e76953 to 8b1ce75 Compare December 5, 2025 15:51
_task: Arc<Task<Result<(), gpui_tokio::JoinError>>>,
}

impl Drop for WasmExtension {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming, is this removal intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants