feat(media_deletion): New approach for handling async deletion of attachments#1011
Merged
feat(media_deletion): New approach for handling async deletion of attachments#1011
Conversation
…base and file storage provider
cloedu87
added
enhancement
cloedu87
commented
Dec 17, 2025
cloedu87
commented
Dec 17, 2025
…. just throw the error if there is one.
9 tasks
…f not permitted to execute collection delete
cloedu87
changed the title
sidler92
previously approved these changes
Jan 5, 2026
Collaborator
sidler92
left a comment
sidler92
left a comment
There was a problem hiding this comment.
This looks nice 👍
Only one question about the attachment migrations.
…on all media entities
* chore: dependency updates and changes to make authentication work w/ new versions * chore: cleaning up test messages * chore(deps): bump actions/cache from 4 to 5
sidler92
previously approved these changes
Jan 5, 2026
Collaborator
sidler92
left a comment
sidler92
left a comment
There was a problem hiding this comment.
One last smalls change needed.
But looks very nice! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The cascade destruction and soft deletion of
Files.Attachmentresources is currently way to slow. The main reason is, that the ashcascade_destroy, which gets triggered whenRecords.Collectionresources get deleted, are running in the application instead of the database and are therefore very slow, are prone to memory problems and are far away acceptable when we have to deal with huge datasets.The approach here is, to add a
Records.Collectionreference to theFiles.Attachmentresource, so we can collect all referenced attachments with one query and soft delete them within the transaction of deleting the collection.This brings:
Related Issue
#979
#812
#970
Type of Change