Open
Conversation
vladdoster
force-pushed
the
fix/help-usage
branch
5 times, most recently
from
1e022e3 to
68adee8
Compare
pschmitt
reviewed
Jun 6, 2023
Member
pschmitt
left a comment
pschmitt
left a comment
There was a problem hiding this comment.
🤔
Should it be Zinit or zinit?
Is it Zsh, zsh, or ZSH?
vladdoster
force-pushed
the
fix/help-usage
branch
from
979635e to
4aaa113
Compare
vladdoster
force-pushed
the
fix/help-usage
branch
2 times, most recently
from
abd968b to
06c16cd
Compare
vladdoster
force-pushed
the
fix/help-usage
branch
from
5c2c63f to
0e691c0
Compare
pschmitt
reviewed
Jun 13, 2023
Comment on lines
-21
to
-49
| # Run ctags to generate Emacs and Vim's format tag file. | ||
| tags: tags/emacs tags/vim | ||
|
|
||
| tags/emacs: ## Build Emacs-style ctags file | ||
| @if type ctags >/dev/null 2>&1; then \ | ||
| if ctags --version | grep >/dev/null 2>&1 "Universal Ctags"; then \ | ||
| ctags -e -R --options=share/zsh.ctags --languages=zsh \ | ||
| --pattern-length-limit=250 --maxdepth=1; \ | ||
| else \ | ||
| ctags -e -R --languages=sh --langmap=sh:.zsh; \ | ||
| fi; \ | ||
| printf "Created the Emacs \`TAGS\` file.\\n"; \ | ||
| else \ | ||
| printf 'Error: Please install a Ctags (e.g.: either the Exuberant or Universal %b' \ | ||
| 'version) utility first.\n'; \ | ||
| fi | ||
|
|
||
| tags/vim: ## Build the Vim-style ctags file | ||
| @if type ctags >/dev/null 2>&1; then \ | ||
| if ctags --version | grep >/dev/null 2>&1 "Universal Ctags"; then \ | ||
| ctags --languages=zsh --maxdepth=1 --options=share/zsh.ctags --pattern-length-limit=250 -R; \ | ||
| else \ | ||
| ctags -R --languages=sh --langmap=sh:.zsh; \ | ||
| fi; \ | ||
| printf "Created the Vim's style \`tags\` file.\\n"; \ | ||
| else \ | ||
| printf 'Error: Please install a ctags first.\n'; \ | ||
| fi | ||
|
|
Member
Author
- lists available ices via `zi ice [-h/-help]` - remove verbiage in `zi help` to improve readability - fix broken formatting of `times` in `zi help` - sort commands alphabetically in `zi help` message Signed-off-by: Doster, Vladislav <mvdoster@gmail.com>
vladdoster
force-pushed
the
fix/help-usage
branch
from
8f96443 to
d0d5a81
Compare
Member
Author
|
Current format is on the left and new on right. |
pschmitt
reviewed
Jun 16, 2023
Comment on lines
-54
to
-63
| @test 'completions-ignored' { | ||
| # only the _valid file should be installed as a completion | ||
| run zinit as"null" id-as"test/ignored_completions" atclone"touch __init__.py _valid" completions for zdharma-continuum/null | ||
| assert $state equals 0 | ||
| assert "$ZPLUGINS/test---ignored_completions/_valid" is_file | ||
| assert "$ZPLUGINS/test---ignored_completions/__init__.py" is_file | ||
| assert "$ZINIT[COMPLETIONS_DIR]/_valid" is_file | ||
| COMPS=( "$ZINIT[COMPLETIONS_DIR]"/_* ) | ||
| assert __init__.py is_not_value_in $COMPS | ||
| } |
Member
There was a problem hiding this comment.
Did you rebase on an old version of main perhaps?
pschmitt
reviewed
Jun 16, 2023
Comment on lines
-557
to
+553
| completions=( "${plugin}"/**/_[^_.]*~*(*.zwc|*.html|*.txt|*.png|*.jpg|*.jpeg|*.js|*.md|*.yml|*.yaml|*.py|*.ri|_zsh_highlight*|/zsdoc/*|*.ps1)(DN^/) ) || \ | ||
| completions=( "${ZINIT[PLUGINS_DIR]}/${id_as//\//---}"/**/_[^_.]*~*(*.zwc|*.html|*.txt|*.png|*.jpg|*.jpeg|*.js|*.md|*.yml|*.yaml|*.py|*.ri|_zsh_highlight*|/zsdoc/*|*.ps1)(DN^/) ) | ||
| completions=( "${plugin}"/**/_[^_.]*~*(*.zwc|*.html|*.txt|*.png|*.jpg|*.jpeg|*.js|*.md|*.yml|*.ri|_zsh_highlight*|/zsdoc/*|*.ps1)(DN^/) ) || \ | ||
| completions=( "${ZINIT[PLUGINS_DIR]}/${id_as//\//---}"/**/_[^_.]*~*(*.zwc|*.html|*.txt|*.png|*.jpg|*.jpeg|*.js|*.md|*.yml|*.ri|_zsh_highlight*|/zsdoc/*|*.ps1)(DN^/) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zinit --helpicecommand usage.-h|--help|helpfirst instead of last--helptoicecommandzinitusage messagelist,clist,ls)Related Issue(s)
N/A
Motivation and Context
Usage examples
before
after
How Has This Been Tested?
Types of changes
Checklist: