feat: implement glob in TauriFSAdapter#4
Open
Alexi5000 wants to merge 1 commit into
Open
Conversation
Replace the TODO stub with a working implementation that recursively walks directories via the existing listDir IPC call and matches file paths against a simple glob-to-regex converter supporting *, **, and ? wildcards. No new dependencies required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glob()method inTauriFSAdapterwhich was a TODO stub that threwError("glob not implemented")globToRegExp()helper that converts simple glob patterns (*,**,?) to RegExplistDirIPC callFilesystemClient.listDirthat already existsMotivation
The
FSAdapterinterface requires aglob()method, but the Tauri frontend implementation threw an error. While skill discovery currently doesn't call it, any future feature that usesFSAdapter.glob()on the frontend would crash. This resolves the TODO and makes the adapter interface fully implemented.Test Plan
glob("*.md", "/some/dir")returns markdown files in that directoryglob("**/*.ts", "/some/dir")recursively finds TypeScript filesglob("src/index.?s", "/some/dir")matches both.tsand.js