Supercache dev extern&mock#20
Open
qinyufei63 wants to merge 38 commits into
Open
Conversation
① Ubuntu 22.04 三层分发全链路编译验证通过:Layer1 submodule (libubdiag.a + 7 target)、Layer2 system package (find_package成功)、Layer3 mock fallback (header-only零依赖错误),三层cmake configure + make全目标零ubdiag相关报错,仅transfer_engine因glog预存问题失败与本次变更无关 ② pre-commit格式化自动修正:FindUbDiag.cmake缩进从4空格改为2空格(与项目其他CMake文件一致);auto_perf.h模板声明从两行折为一行(Google风格80列内);375个基线文件被pre-commit修改后已全部恢复,仅保留我们的变更 ③ 修复Layer1目标名bug:ubdiag add_subdirectory只创建ubdiag_lib目标不含UbDiag::命名空间,改为if(TARGET ubdiag_lib)+ALIAS创建UbDiag::ubdiag_lib ④ 修复Layer1 include路径bug:ubdiag CMake用CMAKE_SOURCE_DIR引用include,被Mooncake add_subdirectory后指向错误路径,手动补齐BUILD_INTERFACE include目录
…aster 被污染导致 segfault
…ei63/Mooncake into supercache_dev_withscript
748d242 to
af0244e
Compare
added 11 commits
June 15, 2026 10:19
- read.sh: 补完整 summary(exit code + stdout benchmark + key metrics + stderr 错误检测) - write.sh: 同上补 summary(write progress + 错误检测) - verify_3layers_245.sh: 新,逐层编译(L1/L2/L3) + 每层串行 master-client-write-read + 最终三层汇总
… mooncake-store/master/client 被 USE_UB 污染导致 segfault
…segment_size;read.sh关键指标提取改用sed提取FINAL SUMMARY整块;verify_3layers_245.sh 添加-fPIC编译选项并修复rm -f build无法删除目录的问题
…使用系统ubdiag、L3添加系统cmake备份恢复
added 12 commits
June 17, 2026 09:18
…前恢复系统包L3前隐藏并清理构建残留
…real_client_main加IsGoogleLoggingInitialized防御,verify脚本补全9010/8980端口清理
…real_client_main加IsGoogleLoggingInitialized防御
…nt readiness轮询避免竞态
… supercache_dev_withscript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
将 UbDiag 从 Mooncake 编译期硬依赖(
find_package(REQUIRED))改为三层 CMake 自动回退机制,确保用户无论是否安装 UbDiag 均可编译 Mooncake。extern/ubdiaggit submodule,指向 v0.4.0mooncake-common/FindUbDiag.cmake,实现 Layer 1 submodule → Layer 2 system → Layer 3 mock 三层分发mooncake-common/ubdiag-mock/ubdiag/auto_perf.hheader-only mock,全签名对齐真实 UbDiag v0.4.0(含模板构造函数、Abandon、析构、PerfLevel:uint8_t)mooncake-transfer-engine/src/CMakeLists.txt、mooncake-store/src/CMakeLists.txt、mooncake-integration/CMakeLists.txt三处将find_package(UbDiag REQUIRED)替换为include(FindUbDiag.cmake)mooncake-common/ubdiag-mock/README.md集成说明文档Module
mooncake-transfer-engine)mooncake-store)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Ubuntu 22.04 三层分发全链路编译验证:
UbDiag: using submodule (extern/ubdiag)UbDiag: using system packageUbDiag: using mock (no-op PerfPoint)transfer_engine/config.cppglog API 不兼容为预存 issue,与本次变更无关测试命令:
Checklist
./scripts/code_format.sh(auto_perf.h 通过 clang-format;FindUbDiag.cmake 通过 cmake-format,缩进 4→2 空格符合项目惯例)pre-commit run --all-filesand all hooks pass(ruff/codespell 的 43 个报错全部在基线已有代码中,与本次变更无关;新增文件零报错)AI Assistance Disclosure
DeepSeek V4 Pro 辅助了代码审查、mock 签名对齐验证、README 文档撰写、pre-commit 运行与修复、Ubuntu 22.04 环境部署与三层编译验证、commit 管理。人工检查并确认了所有变更的正确性。