Skip to content

Match CGPrgObj playSe3D constant layout#12853

Open
AsclepiusBot wants to merge 1 commit into
mainfrom
pr/agent/1778706327
Open

Match CGPrgObj playSe3D constant layout#12853
AsclepiusBot wants to merge 1 commit into
mainfrom
pr/agent/1778706327

Conversation

@AsclepiusBot
Copy link
Copy Markdown
Collaborator

Summary

  • Remove the hand-defined int-to-float double bias from prgobj.cpp so MWCC emits the compiler-owned bias constant in the expected .sdata2 slot.
  • Move FLOAT_80331BE8 after playSe3D so the generated bias constant keeps the PAL MAP layout and avoids the duplicate .sdata2 entry.

Evidence

  • ninja succeeds.
  • build/tools/objdiff-cli diff -p . -u main/prgobj -o - playSe3D__8CGPrgObjFiiiiP3Vec
    • playSe3D__8CGPrgObjFiiiiP3Vec: 99.90385% -> 100.0%
    • [.sdata2-0]: 88.88889% -> 93.333336%
    • compiled .sdata2 size: 40 -> 28 bytes

Plausibility

  • The PAL MAP names the bias as a compiler local in prgobj.o; defining it manually created a duplicate literal. This keeps source-level constants plausible and lets the compiler generate the conversion constant used by playSe3D.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented May 13, 2026

Report for GCCP01 (8d93249 - e45a75c)

No changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant