Allow validation of code in a subdirectory#52
Open
timothyjward wants to merge 3 commits intozbeekman:masterfrom
Open
Allow validation of code in a subdirectory#52timothyjward wants to merge 3 commits intozbeekman:masterfrom
timothyjward wants to merge 3 commits intozbeekman:masterfrom
Conversation
In some cases validation is needed for a single path within the repository. It should be possible to select that path using a variable such as `REPOSITORY_PATH`
The container validating the editor config may have a different user - this can be fixed up by setting `ADD_SAFE_DIRECTORY` to `true`
Update the file search to work relative to the working directory, not the root of the repository Signed-off-by: Tim Ward <timothyjward@apache.org>
Marusyk
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
I wanted to set up the EditorConfig-Action in my repository but found a couple of blocking issues:
.editorconfigand code to check is in a subfolder within the repositoryactions/checkoutplugin ends up owned by a different user and so needs to be marked as safeBoth of these changes are enabled using properties passed to the action.
You can see the result (from my fork) being used at Eclipse sensiNact
Additional information
Pull request checklist