Korthia's Archive Relics are treated as account-wide, should be per-character #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Korthia's Relics are obtained by non-repeatable one-time quest. They provide good research reward and relics appear per-character visually in archive itself. IMO because of this they should be tracked per-character.
Right now they are removed for every character from map when "remove collected" option is turned on as soon as you obtain relic on any of characters, because parent class (
Treasure)'s:IsCollectedreportstrueas relics have account-wide achievement listed as "reward". I assume it worked before when this achievement wasn't account-wide.This simple fix gives
Relicclass its own:IsCollectedthat always returnsfalse, making HN logic to remove pin when node:IsCompletedinstead.