Prevent broken page layout from table overflow#3256
Open
ritorhymes wants to merge 2 commits intozaproxy:mainfrom
Open
Prevent broken page layout from table overflow#3256ritorhymes wants to merge 2 commits intozaproxy:mainfrom
ritorhymes wants to merge 2 commits intozaproxy:mainfrom
Conversation
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
Member
|
To address the DCO requirement you'll need to sign-off the commit(s): |
ritorhymes
force-pushed
the
fix/table-responsive-scroll
branch
from
274bac2 to
46cb499
Compare
Contributor
Author
|
@kingthorin got it, thanks! I just took care of them. |
thc202
changed the title
ritorhymes
force-pushed
the
fix/table-responsive-scroll
branch
from
05da725 to
edab822
Compare
Member
|
This needs a push (probably worth rebasing), the checks didn't trigger for some reason. |
Allow tables to scroll horizontally internally when they exceed the page width. This prevents tables from expanding the page width, breaking the layout, and causing page-wide horizontal scrolling. Signed-off-by: Rito Rhymes <rito@ritovision.com>
Create a shared .sticky-table utility for tables with sticky top header cells inside a scrollable container. Set a max height and internal vertical scrolling so sticky positioning takes effect and header cells stay above content. Apply it to .market-table and move those styles from addons.scss into _tables.scss, where shared table styles belong. Signed-off-by: Rito Rhymes <rito@ritovision.com>
ritorhymes
force-pushed
the
fix/table-responsive-scroll
branch
from
edab822 to
2bdab64
Compare
Contributor
Author
|
Done. Updated the commit msg clarity too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tables throughout the site are not mobile responsive and cause horizontal page overflow when they're too wide to fit on the page. This breaks the layout on mobile and introduces difficulties scrolling around the page.
This fix:
_tables.scssfor table helper styles..sticky-tableclass to allow tables' top row of cells to remain fixed for context while scrolling..market-tablewith.sticky-tableso the top filter row is always accessible..market-tablefromaddons.scssinto_tables.scsssince it is reused on multiple pages.Pages with tables that had page overflow:
/docs/internal-statistics//docs/internal-events//docs/constants//docs/alerts/You can test the fix out on this page of the demo site zaproxy.ritovision.com/docs/constants/
Before and After
Recorded on an Android Chrome browser, screen size about 450px.
Before
zaproxy-tables-before_1.webm
After
zaproxy-tables-after.webm