ascanrulesAlpha: Add getExampleAlerts to SQLite SQLi timing rule#7224
Merged
thc202 merged 1 commit intozaproxy:mainfrom Mar 31, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
3 tasks
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
|
New Issues (161)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
thc202
reviewed
Mar 24, 2026
kingthorin
reviewed
Mar 24, 2026
Comment on lines
+468
to
+469
| detectableDelayParameter, | ||
| detectableDelayParameter, |
Member
There was a problem hiding this comment.
This looks strange, do we really want to pass the same value twice?
Contributor
Author
There was a problem hiding this comment.
Oh I didn't even realize that, I just removed the duplicate param.
kingthorin
approved these changes
Mar 28, 2026
Add getExampleAlerts() to SqlInjectionSqLiteTimingScanRule for documentation generation (Issue 6119). Extracts alert building into reusable helper methods and returns example alerts for both error-based and timing-based detection paths. Signed-off-by: Karl Seryani <karlseryani@gmail.com>
thc202
force-pushed
the
feat/6119-sqlite-example-alerts
branch
from
cfe3522 to
68c2b1a
Compare
thc202
approved these changes
Mar 31, 2026
Member
|
Thank you! |
psiinon
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds
getExampleAlerts()toSqlInjectionSqLiteTimingScanRulefor documentation generation purposes.Changes
buildErrorAlert()andbuildTimingAlert()helper methodsgetExampleAlerts()returning example alerts for both detection paths (error-based and timing-based)40024-1(error-based) and40024-2(timing-based)shouldHaveExpectedExampleAlerts()Related Issues
Contributes to zaproxy/zaproxy#6119
Test Plan
./gradlew :addOns:ascanrulesAlpha:checkpassesshouldAlertIfSqlErrorReturned,shouldAlertIfRandomBlobTimesGetLonger,shouldNotAlertIfAllTimesGetLonger)shouldHaveExpectedAlertRefsInExampleAlertspassesshouldHaveExpectedExampleAlertspasses