fix(clone_with_wale): fix script to work with wal-g master#979
Open
peterparser wants to merge 1 commit intozalando:masterfrom
Open
fix(clone_with_wale): fix script to work with wal-g master#979peterparser wants to merge 1 commit intozalando:masterfrom
peterparser wants to merge 1 commit intozalando:masterfrom
Conversation
|
No need to work with master anymore as wal-g team just cutted a brand new release. More on #986 |
Author
Hi @gabrielmocan, the problem was affecting wal-g master and from what I see in #987 test logs is also affecting this new release. |
There's more work to do in this PR, still a draft. Just wait... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with a wal-g binary built from master branch and spilo, I found out that the newer version of wal-g uses
backup_nameinstead ofnamein the output of the command, this change make the script not functional during a restore operation.The change is pretty straightforward, it's also needed to replace the
backup_nameword tonameto make sure that the dictionary is created accordingly to the rest of the script and to support also older versions of wal-g.