fix: implement container-aware CPU detection#1170
Open
jorsol wants to merge 2 commits intozalando:triggerfrom
Open
fix: implement container-aware CPU detection#1170jorsol wants to merge 2 commits intozalando:triggerfrom
jorsol wants to merge 2 commits intozalando:triggerfrom
Conversation
Instead of returning the host's physical CPU count, this now checks Cgroup v1/v2 quotas and process affinity. This ensures the application scales based on available container resources rather than host hardware.
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Author
|
Any comment on this? |
Member
|
please fix the flake8 issues: https://github.com/zalando/spilo/actions/runs/24730351030/job/72342837925?pr=1170 |
hughcapet
reviewed
Apr 21, 2026
| try: | ||
| limit = len(os.sched_getaffinity(0)) | ||
| except (AttributeError, NotImplementedError): | ||
| limit = os.cpu_count() or 1 |
Member
There was a problem hiding this comment.
why do you prefer to switch to os.cpu_count from the psutil.cpu_count()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning the host's physical CPU count, this now checks Cgroup v1/v2 quotas and process affinity. This ensures the application scales based on available container resources rather than host hardware.