You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the @scrolloop/vue package, providing a Vue 3 adapter for the core library. It includes the InfiniteList and VirtualList components, the useInfinitePages composable, and the necessary build configuration. Feedback was provided regarding the InfiniteList.vue component to refactor repetitive inline centering styles into a scoped CSS class to improve maintainability and reduce code duplication.
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the Vue 3 adapter for @scrolloop, including the VirtualList and InfiniteList components and the useInfinitePages composable. The review feedback identifies a critical reactivity issue in the useInfinitePages composable where options can become stale, a logic inefficiency in InfiniteList.vue regarding redundant page loads, and a suggestion to deduplicate inline styles for better maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.