ci(manifest): add lint workflow; prune ancient Zsh 5.1.1/5.2.4#14
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Salvages the still-relevant parts of a stale branch: adds a manifest lint workflow and removes obsolete Zsh 5.1.1 / 5.2.4 versions from the generator, manifest, and README.
Changes:
- Drop
5.1.1and5.2.4fromVERSIONSinscripts/build-manifest.pyand regeneratepackage.json. - Remove corresponding README pack examples.
- Add
.github/workflows/manifest-lint.ymlthat validatespackage.jsonJSON,zsh-datastructure, and drift vs the generator.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/build-manifest.py |
Prune ancient 5.1.1 and 5.2.4 from VERSIONS |
package.json |
Remove generated entries for the pruned versions |
docs/README.md |
Remove zi pack"5.2.4" / "5.1.1" examples |
.github/workflows/manifest-lint.yml |
New CI job: parse, structural checks, generator-drift check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ss-o
force-pushed
the
feature-manifest-lint-prune
branch
from
93a2956 to
2380fdd
Compare
Validate package.json parses, has the expected zsh-data structure, and is up-to-date with scripts/build-manifest.py on pushes/PRs touching the manifest or its generator. Declares least-privilege read-only permissions and pins the checkout action to a full commit SHA per workspace policy.
Remove the two oldest selectable profiles from the generator's VERSIONS list, regenerate package.json (default + 8 versions), and trim the matching README install examples. The unpinned default and 5.3.1+ profiles are unaffected.
ss-o
force-pushed
the
feature-manifest-lint-prune
branch
from
2380fdd to
2f04dda
Compare
ss-o
added a commit
to z-shell/wiki
that referenced
this pull request
May 31, 2026
The zsh package no longer ships 5.1.1 or 5.2.4 as selectable profiles (z-shell/zsh#14). Remove the two stale 'zi pack' examples so the usage page matches the available manifest profiles.
ss-o
added a commit
to z-shell/wiki
that referenced
this pull request
Jun 1, 2026
* docs(zsh-lint): add generated-reference markers (#755) docs(zsh-lint): add generated-reference markers and seed content Re-add the {/* zsh-lint:generated:start/end */} markers to the Zsh Lint ecosystem page so the wiki-docs-sync pipeline from z-shell/zsh-lint has a region to inject into. Seed the region with the current generated Go reference so the first automated sync is a no-op rather than a failure. The marked region is machine-managed — do not hand-edit; it is regenerated from the repo's Go doc comments. Co-authored-by: Salvydas Lukosius <ss-o@users.noreply.github.com> * docs(zsh-lint): sync generated reference (#756) docs(zsh-lint): sync generated reference from zsh-lint * ci(trunk): fix duplicate Trunk Check context blocking PRs (#759) ci(trunk): rename workflow/job to Trunk Code Quality to fix duplicate check context The workflow and job were both named 'Trunk Check', colliding with the check that trunk-io/trunk-action posts (also 'Trunk Check'). Two identically-named check-runs confuse strict branch protection (required context 'Trunk Check'), leaving PRs stuck in BLOCKED even when all checks pass. Renaming to the org-conventional 'Trunk Code Quality' (matching other repos) leaves the action's 'Trunk Check' as the sole required context. Fixes #757. Co-authored-by: Salvydas Lukosius <ss-o@users.noreply.github.com> * docs(packages): drop removed Zsh 5.1.1/5.2.4 from version list The zsh package no longer ships 5.1.1 or 5.2.4 as selectable profiles (z-shell/zsh#14). Remove the two stale 'zi pack' examples so the usage page matches the available manifest profiles. * docs(zsh-lint): move tool documentation into community * docs(zsh-lint): normalize generated reference indentation * ci(workflows): enforce concurrency and permissions rules * ci(workflows): enforce top-level policy blocks --------- Co-authored-by: Salvydas Lukosius <ss-o@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages the still-relevant parts of the stale
feature-zsh13-manifest-dedupbranch. The branch's/bin/zshopt-in + manifest-dedup work was already merged (and hardened further) ind4e92dd("Closes ZSH-13"), so only the genuinely-new pieces are brought forward here, rebuilt on top of currentmain:1. Manifest lint workflow (
ci(manifest))package.jsonparses and has the expectedzsh-datastructure.package.jsondrifts fromscripts/build-manifest.pyoutput.2. Prune ancient Zsh versions (
build(package))5.1.1and5.2.4from the generator'sVERSIONS; regeneratepackage.json(default + 8 versions); trim matching README examples.Verified locally: all three workflow steps pass,
package.jsonis stable on re-run, valid JSON, and the safer/bin/zshinstall guards frommain(!= 1+ refuse-clobber/bin/zsh.bkp) are preserved — no safety regression.🤖 Generated with Claude Code