ci(trunk): refresh caller workflow#12
Open
ss-o wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refreshes this repo’s Trunk GitHub Actions “caller” workflow to match the newer org-level single-job reusable-workflow pattern, removing the old scheduled upload/token wiring and tightening execution controls.
Changes:
- Convert to a single
checkjob callingz-shell/.github/.github/workflows/trunk.yml@mainand remove the separate scheduleduploadjob /TRUNK_TOKENsecret mapping. - Add explicit workflow/job permissions and a workflow-level concurrency policy.
- Pass
arguments: --no-progressinto the reusable Trunk workflow.
Comments suppressed due to low confidence (1)
.github/workflows/trunk-check.yml:19
- With
concurrency.cancel-in-progress: trueandgroup: ${{ github.workflow }}-${{ github.ref }}, the scheduled run (ref =refs/heads/main) can cancel an in-progress push/manual run onmain(and vice-versa). If you want scheduled runs to be independent, include${{ github.event_name }}in the group or otherwise differentiate schedule runs from push/dispatch runs.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
8
to
12
| pull_request: | ||
| types: [opened, synchronize] | ||
| types: [opened, synchronize, reopened] | ||
| schedule: | ||
| - cron: "0 05 * * 5" | ||
| workflow_dispatch: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRUNK_TOKENpath.arguments: --no-progress.Part of z-shell/.github#408.
Verification
.github/workflows/trunk-check.yml.Agent handoff
Status: Ready for review
Current state: PR contains only the Trunk caller refresh.
Blockers: None known.
Next steps: Wait for PR CI; merge if green.