Replace Thread.isAlive() with Thread.is_alive() #473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
mkb79
reviewed
Mar 6, 2023
Contributor
mkb79
left a comment
mkb79
left a comment
There was a problem hiding this comment.
Looks good to me.
FYI:
SUITextView must be replaced with SUITextView_PY3 on Python == 3.* in another PR. Otherwise Pythonista 3.4 still crashes.
Collaborator
Author
|
Yes. I am trying to break #463 into bite-sized chunks so we can get it all merged. |
cclauss
force-pushed
the
isAlive-to-is_alive
branch
from
b150c07 to
724d00a
Compare
Collaborator
Author
|
@bennr01 Migrated to |
Collaborator
Author
|
Closing in favor of #478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread.is_alive()was added in Python 2.6 so we can change.isAlive()to.is_alive()everywhere to be compatible with all versions of Pythonista.