Dockerize smallfactory#5
Open
reinauer wants to merge 1 commit into
Open
Conversation
yusufm
reviewed
Aug 11, 2025
|
|
||
| # Git configuration for commits made from within the container | ||
| SF_GIT_USER_NAME=Your Name | ||
| SF_GIT_USER_EMAIL=your.email@example.com No newline at end of file |
Owner
There was a problem hiding this comment.
should we have ability to add a ssh key for git access?
Author
|
Has this one been obsoleted by your other Dockerfile implementation? |
Owner
|
Yes, existing docker support should get you wan you need. Docs have
details.
…On Thu, Apr 16, 2026 at 4:22 PM Stefan Reinauer ***@***.***> wrote:
*reinauer* left a comment (yusufm/smallfactory#5)
<#5 (comment)>
Has this one been obsoleted by your other Dockerfile implementation?
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADREEF7H5IHXPCEJOLXFUD4WFTMTAVCNFSM6AAAAACX4HG5CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENRUGA3TOMJTG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.