Added function render function option#96
Open
imbedhead wants to merge 3 commits intoyury-dymov:masterfrom
Open
Added function render function option#96imbedhead wants to merge 3 commits intoyury-dymov:masterfrom
imbedhead wants to merge 3 commits intoyury-dymov:masterfrom
Conversation
yury-dymov
requested changes
Apr 16, 2023
Owner
yury-dymov
left a comment
yury-dymov
left a comment
There was a problem hiding this comment.
Overall changes look great!
Please address some nits and let's also change 52 to the proper item height evaluation. Depends on styles and custom element renderers the height may vary so we would really like to be able support all kinds of heights. I promise to review much faster next time.
| offsetY: 0, | ||
| value: null, | ||
| passThroughEnter: false, | ||
| renderOptionsList: (markUp, plaintext)=> markUp, |
Owner
There was a problem hiding this comment.
nit: (markUp, plaintext) => markUp,
|
|
||
| const helperOptions = options.slice(0, optionNumber).map((val, idx) => { | ||
| const highlightStart = val.toLowerCase().indexOf(value.substr(matchStart, matchLength).toLowerCase()); | ||
| height -= 52; |
Owner
There was a problem hiding this comment.
Why 52? Magic constant here is confusing
| }); | ||
|
|
||
| if (!expandUp) { | ||
| height = top + offsetY; |
Owner
There was a problem hiding this comment.
The way logic is spreaded for height evaluation if confusing.
Something like below would be cleaner from my perspective:
const height = expandUp ? (offsetY + helperOptions.length * optionHeight) : top + offsetY;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.