Skip to content

YPE-1000: feat(verse-of-the-day): update default bible version to niv #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmanquen merged 1 commit into from
Jan 9, 2026
Merged

YPE-1000: feat(verse-of-the-day): update default bible version to niv #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/components/verse-of-the-day.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const Default: Story = {
const callArgs = mockSpy.mock.calls[0]?.[0];
await expect(callArgs).toHaveProperty('text');
await expect(callArgs?.text).toContain('For I am about to do something new');
await expect(callArgs?.text).toContain('Isaiah 43:19 KJV');
await expect(callArgs?.text).toContain('Isaiah 43:19 NIV');
},
};

Expand Down
6 changes: 3 additions & 3 deletions packages/ui/src/components/verse-of-the-day.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type VerseOfTheDayProps = {
*/
background?: 'light' | 'dark';
/**
* The Bible Translation version id to use, defaults to 1 (KJV).
* The Bible Translation version id to use, defaults to 111 (NIV).
*/
versionId?: number;
/**
Expand Down Expand Up @@ -69,7 +69,7 @@ async function share({ title, text, url }: { title?: string; text: string; url?:
* @example
* ```tsx
* <VerseOfTheDay
* versionId={1}
* versionId={111}
* showSunIcon={true}
* showShareButton={false}
* showBibleAppAttribution={true}
Expand All @@ -80,7 +80,7 @@ async function share({ title, text, url }: { title?: string; text: string; url?:
export function VerseOfTheDay({
background,
dayOfYear,
versionId = 1, // KJV by default
versionId = 111, // NIV by default
showSunIcon = true,
showShareButton = true,
showBibleAppAttribution = true,
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/test/mock-data/passages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"ISA.43.19": {
"id": "ISA.43.19",
"content": "<div><div class=\"q1\"><span class=\"yv-v\" v=\"19\"></span><span class=\"yv-vlbl\">19</span>For I am about to do something new.</div><div class=\"q2\">See, I have already begun! Do you not see it?</div><div class=\"q1\">I will make a pathway through the wilderness.</div><div class=\"q2\">I will create rivers in the dry wasteland.</div></div>",
"version_id": 1,
"version_id": 111,
"reference": "Isaiah 43:19"
},
"JHN.1.51": {
Expand Down
6 changes: 1 addition & 5 deletions packages/ui/src/test/mocks/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const globalHandlers = [
}),

// Isaiah passage for verse of the day
http.get('*/v1/bibles/1/passages/ISA.43.19', () => {
http.get('*/v1/bibles/111/passages/ISA.43.19', () => {
return HttpResponse.json(mockPassages['ISA.43.19']);
}),

Expand All @@ -56,10 +56,6 @@ export const globalHandlers = [
return HttpResponse.json(mockBibles.individual['111']);
}),

http.get('*/v1/bibles/1', () => {
return HttpResponse.json(mockBibles.individual['1']);
}),

http.get('*/v1/bibles/1588', () => {
return HttpResponse.json(mockBibles.individual['1588']);
}),
Expand Down