Fixes static analyser issue#175
Fixes static analyser issue#175valeriyvan wants to merge 3 commits intoyourkarma:masterfrom valeriyvan:fixingStaticAnaliserIssue
Conversation
By Apple convention method accepting NSError** should have a non-void return value to indicate whether or not an error occurred Solves static analyser issue
OSStatus status = SecItemDelete((__bridge CFDictionaryRef)removeAttributes);
if (status != errSecSuccess) {
if (error) {
// incorrect. OSStatus is an error from different domain
*error = [JWTErrorDescription errorWithCode:status];
}
return NO;
} |
|
Makes sense. What would be correct way to create error here? |
|
Got it. It should be |
|
@valeriyvan could you check macOS tests? |
|
With or without this fix macOS tests fail. Some weird memory problems. |
|
What did you do by clicking on correct Base64 encode? Because I need to click on the string that will be generated |
|
@valeriyvan Thanks! |
New Pull Request Checklist
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
...