add review skill, curl installer, model inheritance#96
Conversation
…config - skills/review: multi-persona code review with structured findings and optional fix loop - scripts/install.sh: POSIX curl installer with checksum verification for GitHub Releases - agents: remove hardcoded model: sonnet so sub-agents inherit parent model by default - dotagents.yaml: add commented-out mattpocock/skills as external_skills example - README: add curl and mise install methods
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new installation script (scripts/install.sh), updates the installation instructions in the README.md, removes the hardcoded model field from several agent configurations, and adds a new multi-persona code review skill (SKILL.md). The review feedback highlights a critical issue in the installation script where stripping the v prefix from the release tag causes 404 download errors. Additionally, it suggests improving the robustness of the review skill by dynamically detecting the default branch instead of hardcoding main, and running the project's test suite or build command during the iterative fix loop to catch regressions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2acec90447
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # curl installer (macOS/Linux, no Go required) | ||
| curl -fsSL https://raw.githubusercontent.com/yourconscience/dotagents/main/scripts/install.sh | sh |
There was a problem hiding this comment.
For users following this new curl path specifically because they do not have Go installed, the next documented step (git clone ... ~/.agents then dotagents setup) still fails: runSetup calls installDotagentsBinary, and for the cloned dotagents source repo that function immediately requires exec.LookPath("go") before syncing. Either setup needs to skip rebuilding when a dotagents binary is already on PATH, or the README should not claim the full setup is "no Go required".
Useful? React with 👍 / 👎.
| git log --oneline main..HEAD | ||
| git diff main...HEAD |
There was a problem hiding this comment.
When /review is run in a clean worktree for a repository whose base branch is not literally main (for example master, trunk, or a detached/temporary branch), these hard-coded commands fail or review against the wrong ref before any personas run. The skill should derive the base from the upstream/default branch (or ask the user) instead of assuming main.
Useful? React with 👍 / 👎.
1 participant
Summary
skills/review/): multi-persona code review with structured findings (Problem/Fix format), severity tiers, optional iterative fix loop. Harness-agnostic -- works with sub-agents on Claude Code/Codex or sequentially on single-agent harnesses.scripts/install.sh): POSIX sh installer for GitHub Releases binaries. Checksum verification, OS/arch detection, PATH hint. Usage:curl -fsSL https://raw.githubusercontent.com/yourconscience/dotagents/main/scripts/install.sh | shmodel: sonnetfrom all 4 agent roles (architect, builder, researcher, reviewer). Sub-agents now inherit parent model by default; explicit override still works via YAML or caller.external_skillsblock for mattpocock/skills (135k stars, MIT) with 4 selected skills (tdd, diagnosing-bugs, domain-modeling, grill-with-docs). Opt-in by uncommenting.Test plan
scripts/install.shruns on macOS (darwin/arm64) -- needs a tagged release to test fullydotagents syncregenerates agent .md files without model field/review main..HEADon a sample diffdotagents pull, verify skills are fetched