Skip to content

Deduplicate e2e test hook helpers#3412

Merged
utam0k merged 5 commits intoyouki-dev:mainfrom
fspv:e2e-dedup-helpers
Apr 4, 2026
Merged

Deduplicate e2e test hook helpers#3412
utam0k merged 5 commits intoyouki-dev:mainfrom
fspv:e2e-dedup-helpers

Conversation

@fspv
Copy link
Copy Markdown
Contributor

@fspv fspv commented Feb 18, 2026

Description

There is some duplication in the e2e tests for hooks. This PR moves similar functions to the helpers library so we can reuse them across the tests.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

#3406
#3408

Additional Context

Was raised here #3406 and here #3408
The functions in the tests in those PRs will be also deduplicated once they're landed and this PR is rebased on main.

Comment thread tests/contest/contest/src/utils/support.rs Outdated
Comment thread tests/contest/contest/src/utils/support.rs
fspv added 5 commits March 29, 2026 23:57
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
@fspv fspv force-pushed the e2e-dedup-helpers branch from e26785e to 24fb088 Compare March 29, 2026 23:04
Copy link
Copy Markdown
Member

@saku3 saku3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Personally, I think the ideal structure is to keep all hook-related tests under the hooks directory.
That way, the tests are grouped by feature, which makes them easier to discover, maintain, and extend as more hook-related cases are added.

e.g.

hooks/
  mod.rs
  helpers.rs
  invoke.rs
  prestart.rs
  create_runtime.rs
  poststart.rs
  poststop.rs

@saku3
Copy link
Copy Markdown
Member

saku3 commented Apr 1, 2026

If there are no comments from @utam0k , I’ll merge it this week.

@utam0k utam0k merged commit 0341ce2 into youki-dev:main Apr 4, 2026
42 of 43 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants