refactor: PrinterBed configuration
#5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
|
Collaborator
Author
|
PR is a draft until I can verify functionality with the test suite PR. |
Laura7089
force-pushed
the
feat/bed-object
branch
2 times, most recently
from
f99b5cd to
0b9750e
Compare
Laura7089
force-pushed
the
feat/bed-object
branch
from
0b9750e to
53cda57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows API consumers of
seanceto specify their print bed information on a case-by-case basis. The existing GCC Spirit settings are provided as a constant.It also reworks the API for unit conversions, moving them into an all-in-one method and introducing sanity+sanity checks for passed values.
Notes