feat: Refine get_file_contents tool with allow_raw_fallback parameter#4
Closed
feat: Refine get_file_contents tool with allow_raw_fallback parameter#4
Conversation
…add allow_raw_fallback
…pe for mock handlers
… and add new test cases for allow_raw_fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback from
github/github-mcp-server#599.Changes
allow_raw_fallbackparameter toget_file_contentstool:false, the tool will always use the Get Contents API endpoint, ensuring that the file's SHA is included in the response.trueto avoid breaking existing functionality for large files.fmt.Errorfwithmcp.NewToolResultErrorin the modified tool for consistent error reporting.allow_raw_fallbackparameter for bothtrueandfalsescenarios.All unit tests pass successfully.