Skip to content

fix(frontend): リアクション変更時に古いリアクションが削除されないことがある問題の修正#898

Merged
kozakura913 merged 1 commit intoyojo-art:developfrom
4ster1sk:fix/emoji3
Apr 4, 2026
Merged

fix(frontend): リアクション変更時に古いリアクションが削除されないことがある問題の修正#898
kozakura913 merged 1 commit intoyojo-art:developfrom
4ster1sk:fix/emoji3

Conversation

@4ster1sk
Copy link
Copy Markdown
Contributor

@4ster1sk 4ster1sk commented Mar 21, 2026

What

fix #896

Why

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 self-requested a review March 21, 2026 12:20
@4ster1sk 4ster1sk marked this pull request as draft March 21, 2026 12:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 19.22%. Comparing base (0d758d1) to head (58c6eb9).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #898      +/-   ##
===========================================
+ Coverage    19.20%   19.22%   +0.02%     
===========================================
  Files          954      954              
  Lines        97008    97037      +29     
  Branches      1428     1428              
===========================================
+ Hits         18628    18657      +29     
  Misses       78373    78373              
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@4ster1sk 4ster1sk marked this pull request as ready for review March 21, 2026 14:49
@4ster1sk
Copy link
Copy Markdown
Contributor Author

「:hogehoge:のリアクションを取り消しますか」とか「:hogehoge:のリアクションに変更しますか」に表示できるようにしようかと思ったけどまぁそっちは別PRかなあ

@4ster1sk 4ster1sk changed the title fix(frontend): リアクション編集時に古いリアクションが削除されないことがある問題の修正 fix(frontend): リアクション変更時に古いリアクションが削除されないことがある問題の修正 Mar 21, 2026
@kozakura913
Copy link
Copy Markdown
Member

動いた

@kozakura913 kozakura913 added this to the 1.7.2 milestone Apr 4, 2026
@kozakura913 kozakura913 merged commit 6b750a4 into yojo-art:develop Apr 4, 2026
22 checks passed
@4ster1sk 4ster1sk deleted the fix/emoji3 branch April 4, 2026 11:47
@kozakura913 kozakura913 mentioned this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

リアクションを編集したときにリアクションが正しく反映されない

2 participants