Fix: add language-server-bitbake as a dependence#178
Fix: add language-server-bitbake as a dependence#178Freed-Wu wants to merge 1 commit intoyoctoproject:stagingfrom
Conversation
3fdb269 to
c8bb651
Compare
|
Can we add |
Adding a binary object is not a good git practice. We actually do that for the .wasm but I'm not a fan of it. I think the fetch time is not obnoxious in my developper experience or the CI, it's not as long as compiling or running tests. Also during development it must only be run once. What is your use case where you find it to be too slow? |
Perhaps due to my poor network? 😢 |
|
Any other problems about this PR? |
The debug configurations must be updated (.vscode/launch.json & tasks.json). |
deribaucourt
left a comment
There was a problem hiding this comment.
Debug configurations and release need to be fixed
I am not familiar with |
This is the tricky part... I think it requires a lot of thought and clever refactoring of the whole packaging system. Hence why I haven't touched it yet. It's not something I can prioritize right now. It's rather a nice to have and doesn't appear to be blocking for any feature or bug fix. |
Decouple client and server
|
Rebased to HEAD and test passed. Can we merge this PR then see and fix any new problems? |
I can't merge a PR that breaks all our development tools. It would block all other developments and debugging. |
OK, let us wait the tricky part 😄 |
Decouple client and server