Expose initial broad prior value (va_init) as constructor parameter#97
Merged
Conversation
- Add va_init option to _build_options defaults (1000.0) - Thread va_init through _initialize_parameters in _full_update.py - Add va_init parameter to VBPCA.__init__, fit(), and get_options() - Add tests for default, propagation, and behavioral effect Closes #94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
va_initas an optional parameter on theVBPCAconstructor, defaulting to1000.0(current behavior). This allows the convergence study (Phase 3a Morris screening) to sweep the initial broad prior value over a range (100–10,000).Changes
_pca_full.py: Add"va_init": 1000.0to_build_optionsdefaults_full_update.py: Replace hardcoded1000.0withopts.get("va_init", 1000.0)in_initialize_parametersestimators.py: Addva_initparameter to__init__, thread throughfit()andget_options()test_estimators.py: Add 3 tests (default value, propagation, behavioral effect)Validation
just cipasses (format, lint, typecheck, 90% coverage).Closes #94