feat(estimators): expose niter_broadprior on VBPCA constructor#96
Merged
Merged
Conversation
Add niter_broadprior as a named keyword argument on VBPCA.__init__() so users can control the broad-prior warmup phase without resorting to **opts. Default remains 100 (backward compatible). Wire the parameter through fit() and get_options(). - Add 3 tests: stored value, default fallback, iteration count effect Closes #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Summary
Adds
niter_broadprioras a named keyword argument onVBPCA.__init__()so users can control the broad-prior warmup phase length directly, without passing it through**opts.Changes
src/vbpca_py/estimators.py— Addniter_broadprior: int | None = Noneparameter to__init__, wire throughfit()andget_options(). Documented in docstring.tests/test_estimators.py— 3 new tests: stored value, default fallback to 100, lower value allows earlier convergence.Backward compatible
Default is
None→ library default of 100 is used. No change for existing callers.CI
434 tests pass, 90.04% coverage.