Skip to content

fix: close span tag in copy button HTML#201

Merged
yoavbls merged 1 commit intoyoavbls:mainfrom
corazzione:main
Mar 29, 2026
Merged

fix: close span tag in copy button HTML#201
yoavbls merged 1 commit intoyoavbls:mainfrom
corazzione:main

Conversation

@corazzione
Copy link
Copy Markdown
Contributor

Summary

The copy button in htmlCodeBlock.ts had a malformed HTML — the closing <span> tag was written as <span> instead of </span>, leaving the inner span element unclosed and opening a new unclosed span before </button>.

Before:

<button class="copy-button" data-copy-content>
  <span class="codicon codicon-copy" title="Copy type to clipboard">
  <span>  <!-- ← wrong: opens a new span instead of closing -->
</button>

After:

<button class="copy-button" data-copy-content>
  <span class="codicon codicon-copy" title="Copy type to clipboard"></span>
</button>

Test plan

  • All 33 tests pass (packages/formatter: 27, packages/vscode-formatter: 6)
  • TypeScript clean on both packages after workspace deps are built

Copy link
Copy Markdown
Owner

@yoavbls yoavbls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yoavbls yoavbls merged commit e315249 into yoavbls:main Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants