Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/vscode-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Pretty TypeScript Errors",
"publisher": "YoavBls",
"description": "Make TypeScript errors prettier and more human-readable in VSCode",
"version": "0.8.5",
"version": "0.8.6",
"icon": "assets/icon.png",
"repository": {
"type": "git",
Expand Down
8 changes: 7 additions & 1 deletion apps/vscode-extension/src/provider/webviewViewProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ export function registerWebviewViewProvider(context: ExtensionContext) {
context.subscriptions.push(
vscode.window.registerWebviewViewProvider(
"prettyTsErrors.sidePanel",
viewProviderInstance
viewProviderInstance,
{ webviewOptions: { retainContextWhenHidden: true } }
),
vscode.languages.onDidChangeDiagnostics(() => updateHasErrorsContext()),
vscode.window.onDidChangeActiveTextEditor(() => updateHasErrorsContext())
Expand Down Expand Up @@ -97,6 +98,7 @@ async function diagnosticToItem(
class MarkdownWebviewViewProvider implements vscode.WebviewViewProvider {
private disposables = new Map<vscode.WebviewView, vscode.Disposable[]>();
private webview: vscode.Webview | null = null;
private view: vscode.WebviewView | null = null;
private mode: ViewMode = "cursor";
private lockedContent: DiagnosticItem | null = null;
private pinnedError: PinnedError | null = null;
Expand Down Expand Up @@ -204,6 +206,7 @@ class MarkdownWebviewViewProvider implements vscode.WebviewViewProvider {
_context: vscode.WebviewViewResolveContext
): Promise<void> {
this.webview = webviewView.webview;
this.view = webviewView;

const initialContent = await this.getActiveContentHtml();
webviewView.webview.html = await this.provider.getWebviewContent(
Expand Down Expand Up @@ -265,6 +268,7 @@ class MarkdownWebviewViewProvider implements vscode.WebviewViewProvider {
disposables?.forEach((disposable) => disposable.dispose());
this.disposables.delete(webviewView);
this.webview = null;
this.view = null;
});
}

Expand Down Expand Up @@ -307,6 +311,8 @@ class MarkdownWebviewViewProvider implements vscode.WebviewViewProvider {
}

async refresh(webview: vscode.Webview) {
if (this.view && !this.view.visible) return;

const sections: string[] = [];

// Render pinned error section
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading