Skip to content

Minor cleanup#13

Merged
BigRoy merged 9 commits intodevelopfrom
enhancement/cleanup
Jan 26, 2026
Merged

Minor cleanup#13
BigRoy merged 9 commits intodevelopfrom
enhancement/cleanup

Conversation

@BigRoy
Copy link
Copy Markdown
Contributor

@BigRoy BigRoy commented Dec 17, 2025

Changelog Description

Additional review information

I'm a bit confused by SceneOS.

  1. The comment states: Possible values are windows, linux, osx
  2. get_rr_platform returns windows, linux, mac
  3. This page of Royal Render for .xml says: Possible values are windows, linux, osx?
  4. This page of Royal Render for .localtex says: Values can be win, lx or mac.

So which is it?

This made me think 2) was wrong on our end, so I changed that to use osx but I'm still confused by 4). But I guess .localtex files just have different SceneOS format.

Testing notes:

  1. Check code changes

@BigRoy BigRoy requested a review from kalisp December 17, 2025 21:25
@BigRoy BigRoy self-assigned this Dec 17, 2025
@BigRoy BigRoy added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Dec 17, 2025
@kalisp
Copy link
Copy Markdown
Member

kalisp commented Dec 22, 2025

  1. The comment states: Possible values are windows, linux, osx

This will be more question for @h-schoenberger

@h-schoenberger
Copy link
Copy Markdown

h-schoenberger commented Dec 28, 2025

I'm a bit confused by SceneOS.
1. The comment states: Possible values are windows, linux, osx
2. get_rr_platform returns windows, linux, mac
3. This page of Royal Render for .xml says: Possible values are windows, linux, osx?
4. This page of Royal Render for .localtex says: Values can be win, lx or mac.

First: Yes, Localtex is a different file type.
Although the SceneOS specs are the same as for submission xml files:

You may use any of the above values.
windows, linux, osx, win, lx or mac.

Note:
If you do not set SceneOS at all, it uses the OS of the machine that you used to submit
Exception: The output and scene file paths are clearly not matching the OS. (Like \fileserver on Linux.)

Comment thread client/ayon_royalrender/rr_job.py Outdated
@BigRoy
Copy link
Copy Markdown
Contributor Author

BigRoy commented Jan 12, 2026

@kalisp can you check and approve if ok please, ready to merge.

Comment thread client/ayon_royalrender/rr_job.py Outdated
@BigRoy BigRoy requested a review from antirotor January 20, 2026 23:56
Comment thread client/ayon_royalrender/rr_job.py Outdated
@BigRoy BigRoy merged commit f285543 into develop Jan 26, 2026
1 check passed
@BigRoy BigRoy deleted the enhancement/cleanup branch January 26, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants