Add slate frame to collected frame sequence.#272
Open
JoseCovaOS wants to merge 2 commits into
Open
Conversation
BigRoy
reviewed
Jun 19, 2026
Comment on lines
+431
to
+448
| def _get_collected_frames_with_slate(self, instance): | ||
| """Get collected frames and include slate frame if available. | ||
|
|
||
| Args: | ||
| instance (pyblish.api.Instance): pyblish instance | ||
|
|
||
| Returns: | ||
| list: collected frames with slate if available | ||
| """ | ||
|
|
||
| first_frame, _ = self._get_frame_range_data(instance) | ||
| collected_frames = self._get_collected_frames(instance) | ||
|
|
||
| return self._add_slate_frame_to_collected_frames( | ||
| instance, | ||
| collected_frames, | ||
| first_frame | ||
| ) |
Member
There was a problem hiding this comment.
Doesn't have to be an extra method I'd say. This logic can just live at the end of _get_collected_frames because it applies to all calls to it anyway.
Contributor
Author
There was a problem hiding this comment.
Sure, have pushed the change :D
Comment on lines
-366
to
368
| if not os.path.exists(expected_slate_path): | ||
| if os.path.exists(expected_slate_path): | ||
| slate_frame = os.path.basename(expected_slate_path) | ||
| collected_frames.insert(0, slate_frame) |
Member
There was a problem hiding this comment.
Hmm, this does make more sense 🤔 - @jakubjezek001 @moonyuet any thoughts?
BigRoy
added
type: bug
moonyuet
approved these changes
Jun 20, 2026
moonyuet
left a comment
moonyuet
left a comment
Member
There was a problem hiding this comment.
Tested successfully in Nuke 16.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #271
Changelog Description
Fixed publishing with
use existing frames - farmfor Nuke renders that include a slate frame. The collector now includes the existing slate frame in the collected frame list before setting expected files, preventing a one-frame offset during integration.Additional review information
When publishing existing frames through the
frames_farmrender target, the collector only gathered the regular render frame range and used that list to populateexpectedFiles. For instances with the slate family, this meant the publish/integration path expected a slate frame at frameStart - 1, but the collected file list did not include that actual slate filename.This PR reuses the existing slate-frame collection logic by calling
_add_slate_frame_to_collected_frames()for the frames_farm path as well. This keeps the behavior aligned with the regularuse existing framespath without calling_set_existing_files_data(), avoiding unintended representation creation for farm publishing.The change is scoped to collection of expected files for
frames_farmpublishes and should only affect Nuke instances that have a slate frame available in the output sequence.Testing notes