Skip to content

fix: version imprint defaults to None for missing keys#269

Open
sebastianbrandhuber wants to merge 1 commit into
ynput:developfrom
sebastianbrandhuber:bugfix/268-ignore_missing_version_keys_in_grouploader_data_imprint
Open

fix: version imprint defaults to None for missing keys#269
sebastianbrandhuber wants to merge 1 commit into
ynput:developfrom
sebastianbrandhuber:bugfix/268-ignore_missing_version_keys_in_grouploader_data_imprint

Conversation

@sebastianbrandhuber

@sebastianbrandhuber sebastianbrandhuber commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Changelog Description

Missing keys in version data imprint will not result in a key error anymore and are eventually removed from the data dictionary.

Additional review information

More information about this here

Fix #268

Testing notes:

  1. Have a published gizmo where one of these attributes is missing:
            "frameStart",
            "frameEnd",
            "handleStart",
            "handleEnd",
            "source",
            "fps"

for example a custom LUT ingest where frameStart or frameEnd could not be determined.
3. Load the gizmo with the loader - should not fail.

@sebastianbrandhuber sebastianbrandhuber marked this pull request as ready for review June 17, 2026 14:46

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - None values are skipped below.

@BigRoy BigRoy requested review from jakubjezek001 and rdelillo June 17, 2026 15:06
@BigRoy BigRoy added type: bug Something isn't working community Issues and PRs coming from the community members labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Issues and PRs coming from the community members type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NukeGroupLoader: _get_imprint_data() errors for non-existing version keys

3 participants