Add context reset prompt on taskChange#266
Conversation
BigRoy
left a comment
There was a problem hiding this comment.
Nice - very nice! Code looks very close to similar functionality in e.g. Maya, Houdini and Fusion integration - and I like such consistency!
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
|
|
||
| change_context_label() | ||
|
|
||
| if _about_to_save: |
There was a problem hiding this comment.
Also pointing out that there is also _before_workfile_save and _after_workfile_save on IWorkfileHost so you can store the _about_to_save on the host itself too.
There was a problem hiding this comment.
@sebastianbrandhuber I assume this is a change still to do?
There was a problem hiding this comment.
Yes, will implement this next week when back at work 👍
|
@moonyuet could you give this a thorough stress test? :) |
moonyuet
left a comment
There was a problem hiding this comment.
The context change is successfully when switching folder and task. but failed to save the workfile.
Recording.2026-06-23.173638.mp4
Error log:
Traceback (most recent call last):
File "<string>", line 9, in <module>
File "C:\Users\Kayla\AppData\Local\Ynput\AYON\addons\core_1.9.6+dev-ayon-ui-qt-launcher\ayon_core\pipeline\create\context.py", line 287, in __init__
self.reset(discover_publish_plugins)
File "C:\Users\Kayla\AppData\Local\Ynput\AYON\addons\core_1.9.6+dev-ayon-ui-qt-launcher\ayon_core\pipeline\create\context.py", line 580, in reset
self.reset_instances()
File "C:\Users\Kayla\AppData\Local\Ynput\AYON\addons\core_1.9.6+dev-ayon-ui-qt-launcher\ayon_core\pipeline\create\context.py", line 1591, in reset_instances
raise CreatorsCollectionFailed(failed_info)
ayon_core.pipeline.create.exceptions.CreatorsCollectionFailed: Failed to collect instances
That sounds quite weird. Does the publisher UI refresh without errors before the save change? And does it still open publisher UI fine after? It's weird it fails on collecting instances, but doesn't in stack trace tell us what it actually errors on. |
It does have error from ayon-deadline-cloud, I will try to disabled that plugins and test if it is related. |
moonyuet
left a comment
There was a problem hiding this comment.
Tested successfully in Nuke 16.0
Changelog Description
This PR implements a pop-up dialog that allows users to interactively choose whether, and what, should be adapted to the new context before a context change callback - very similar to its counterpart in ayon-houdini.
Additional review information
Additional information can be found here in the issue itself:
Fix #265
Testing notes:
Current limitations and unintended bahaviour: