Skip to content

Service tools Makefile fix#269

Open
iLLiCiTiT wants to merge 4 commits into
developfrom
bugfix/service-tools-makefile-fix
Open

Service tools Makefile fix#269
iLLiCiTiT wants to merge 4 commits into
developfrom
bugfix/service-tools-makefile-fix

Conversation

@iLLiCiTiT

@iLLiCiTiT iLLiCiTiT commented May 25, 2026

Copy link
Copy Markdown
Member

Changelog Description

Replaced Makefile with manage.sh to allow the flexibility we need for service tools.

Additional review information

Use correct venv directory and skip first argument when passing arguments to python process.

Testing notes:

  1. Use ./manage.sh services in service_tools.
  2. It should start services running with production settings.
  3. Use ./manage.sh services --variant staging.
  4. It should start services running with staging settings.

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label May 25, 2026
@iLLiCiTiT iLLiCiTiT self-assigned this May 25, 2026
@iLLiCiTiT iLLiCiTiT requested a review from jakubjezek001 May 25, 2026 15:44

@jakubjezek001 jakubjezek001 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running commad this way make services --variant 2026-dev will result in following:

/Library/Developer/CommandLineTools/usr/bin/make: unrecognized option `--variant'
Usage: make [options] [target] ...
Options:
  -b, -m                      Ignored for compatibility.
  -B, --always-make           Unconditionally make all targets.
  -C DIRECTORY, --directory=DIRECTORY
                              Change to DIRECTORY before doing anything.
  -d                          Print lots of debugging information.
  --debug[=FLAGS]             Print various types of debugging information.
  -e, --environment-overrides
                              Environment variables override makefiles.
  -f FILE, --file=FILE, --makefile=FILE
                              Read FILE as a makefile.
  -h, --help                  Print this message and exit.
  -i, --ignore-errors         Ignore errors from commands.
  -I DIRECTORY, --include-dir=DIRECTORY
                              Search DIRECTORY for included makefiles.
  -j [N], --jobs[=N]          Allow N jobs at once; infinite jobs with no arg.
  -k, --keep-going            Keep going when some targets can't be made.
  -l [N], --load-average[=N], --max-load[=N]
                              Don't start multiple jobs unless load is below N.
  -L, --check-symlink-times   Use the latest mtime between symlinks and target.
  -n, --just-print, --dry-run, --recon
                              Don't actually run any commands; just print them.
  -o FILE, --old-file=FILE, --assume-old=FILE
                              Consider FILE to be very old and don't remake it.
  -p, --print-data-base       Print make's internal database.
  -q, --question              Run no commands; exit status says if up to date.
  -r, --no-builtin-rules      Disable the built-in implicit rules.
  -R, --no-builtin-variables  Disable the built-in variable settings.
  -s, --silent, --quiet       Don't echo commands.
  -S, --no-keep-going, --stop
                              Turns off -k.
  -t, --touch                 Touch targets instead of remaking them.
  -v, --version               Print the version number of make and exit.
  -w, --print-directory       Print the current directory.
  --no-print-directory        Turn off -w, even if it was turned on implicitly.
  -W FILE, --what-if=FILE, --new-file=FILE, --assume-new=FILE
                              Consider FILE to be infinitely new.
  --warn-undefined-variables  Warn when an undefined variable is referenced.
  -N OPTION, --NeXT-option=OPTION
                              Turn on value of NeXT OPTION.

This program built for i386-apple-darwin11.3.0
Report bugs to <bug-make@gnu.org>

# Conflicts:
#	service_tools/Makefile
@iLLiCiTiT iLLiCiTiT requested a review from jakubjezek001 June 2, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants