Chore: Reduce and remove dead code#122
Merged
jakubjezek001 merged 15 commits intoJun 16, 2026
Merged
Conversation
rdelillo
added
the
type: maintenance
rdelillo
changed the title
rdelillo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on simplifying the Flame client integration by removing dead/duplicated code paths, tightening logging, and refactoring preference/menu handling while keeping behavior intended to remain unchanged.
Changes:
- Refactors Flame preferences handling into a single read/write helper and cleans up related menu preference access.
- Removes dead code and replaces
print-based diagnostics with structured logging across API modules. - Fixes/cleans up several small logic issues (e.g., XML preset search loop variable, marker data scoping, feed colorspace element creation).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
client/ayon_flame/api/workio.py |
Removes unused bits, clarifies unsupported workfile operations via explicit exceptions. |
client/ayon_flame/api/utils.py |
Updates copy/sync logic and improves comments/clarity around Flame utility scripts. |
client/ayon_flame/api/render_utils.py |
Replaces prints with logging and simplifies preset-path search/validation helpers. |
client/ayon_flame/api/plugin.py |
Cleans up shared state issues (marker data), improves logging, and simplifies filesystem ops. |
client/ayon_flame/api/pipeline.py |
Removes dead callback code and simplifies host/context management scaffolding. |
client/ayon_flame/api/menu.py |
Refactors preference access and reduces duplicated rescan/refresh logic. |
client/ayon_flame/api/lib.py |
Major refactor of preferences I/O and some small cleanup/logging improvements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
11 tasks
…nhancements/cleanup_repo
rdelillo
changed the base branch from
develop
to
enhancement/YN-0620_batchgroup_output_publisher
rdelillo
changed the title
rdelillo
added
the
sponsored
This was
linked to
issues
May 6, 2026
Fix pre-opentimelineio_install pre-hook.
…nhancements/cleanup_repo
jakubjezek001
approved these changes
Jun 16, 2026
jakubjezek001
left a comment
jakubjezek001
left a comment
Member
There was a problem hiding this comment.
Tested via Launching, Publishing and Loading back to my project and all was working as usual.
jakubjezek001
merged commit 9e723d0
into
enhancement/YN-0620_batchgroup_output_publisher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Code polish related to : #84 #124
Testing notes: