Pin Node base image to version 20 to fix uWS incompatibility with latest LTS release#40
Closed
mchris86 wants to merge 1 commit intoyjs:masterfrom
Closed
Pin Node base image to version 20 to fix uWS incompatibility with latest LTS release#40mchris86 wants to merge 1 commit intoyjs:masterfrom
mchris86 wants to merge 1 commit intoyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes build failures in the
serverandworkercontainers caused by the use of Node v22, which is incompatible with the uws library used in this project.The
Dockerfilepreviously used:The
ltstag currently resolves to Node.js v22 which causes the following runtime error:Both
server-1andworker-1containers crash at build.Changes
Replaced the moving LTS tag with a pinned Node.js version(v20):
Tests
Verified that:
serverandworkercontainers now start successfully.