Skip to content

refactor: 删除一行重复代码 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cf-19 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: 删除一行重复代码 #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d83414
refactor: 删除一行重复代码
Oct 21, 2019
cd4ead1
fix: 修复子组件useEffect触发store方法, 无法触发视图数据更新的问题
Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/createStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,20 @@ export default config => {
};

Object.keys(reducers).forEach(key => {
service[key] = (...args) => {
// 将所有方法(通常会改变state)设置成异步代码
// 这样子组件的effect即使比父组件的effect先执行(react hook rule)
// 方法还是会等父组件的effect先执行完再执行
// 这样不会出现数据改变时, queue为空的情况
service[key] = async (...args) => {
service[key].unlock = true;
const promise = reducers[key].apply(service, args);
const promise = await reducers[key].apply(service, args);
if (!isPromise(promise)) {
service[key].unlock = false;
checkUpdateAndBroadcast();
return promise;
}
isChanged = true;
service[key].loading = true;
service[key].unlock = true;
checkUpdateAndBroadcast();
return new Promise((resolve, reject) => {
promise
Expand Down