Skip to content

[WIP] Add options to control method failure handling in the Router middleware#250

Closed
olegbaturin wants to merge 12 commits intoyiisoft:3.xfrom
olegbaturin:249-methodFailure-options
Closed

[WIP] Add options to control method failure handling in the Router middleware#250
olegbaturin wants to merge 12 commits intoyiisoft:3.xfrom
olegbaturin:249-methodFailure-options

Conversation

@olegbaturin
Copy link
Copy Markdown

@olegbaturin olegbaturin commented Oct 25, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #249

next => #266

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 25, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (3.x@3728de1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.x      #250   +/-   ##
=======================================
  Coverage       ?   100.00%           
  Complexity     ?       155           
=======================================
  Files          ?        11           
  Lines          ?       455           
  Branches       ?         0           
=======================================
  Hits           ?       455           
  Misses         ?         0           
  Partials       ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 Need some fixes.

@samdark samdark requested a review from a team October 26, 2024 21:39
@olegbaturin olegbaturin changed the title Add options to control method failure handling in the Router middleware [WIP] Add options to control method failure handling in the Router middleware Nov 8, 2024
@vjik vjik added the status:under development Someone is working on a pull request. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under development Someone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants