Conversation
samdark
commented
Mar 9, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | - |
There was a problem hiding this comment.
Pull request overview
Adds clarifying header comments to Docker environment variable files to document where variables are expected to be visible (Compose interpolation vs container/app runtime).
Changes:
- Add header comments to
docker/dev/.env,docker/test/.env, anddocker/prod/.envabout variables being available in the app/container rather thancompose.yml. - Add a header comment to
docker/.envdescribing variable applicability.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker/test/.env | Adds header comment clarifying intended scope of test env vars. |
| docker/prod/.env | Adds header comment clarifying intended scope of prod env vars. |
| docker/dev/.env | Adds header comment clarifying intended scope of dev env vars. |
| docker/.env | Adds header comment about variable scope (currently misleading vs actual Compose behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docker/.env
Outdated
| # Variables are available in both app and compose.yml. | ||
|
|
There was a problem hiding this comment.
The new header comment is misleading: variables in this file are used by Make/Compose for interpolation (e.g., DEV_PORT/PROD_HOST), but they are not automatically injected into the app container environment unless explicitly passed via environment: or an env_file: entry. Please reword to reflect that these are Compose/Make variables (or document how they become available inside the container if that’s intended).
| # Variables are available in both app and compose.yml. | |
| # Variables in this file are used by Docker Compose/Make for interpolation (e.g. in compose.yml); | |
| # they are not automatically available inside containers unless explicitly passed via `environment:` or an `env_file:`. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
=========================================
Coverage 76.96% 76.96%
Complexity 29 29
=========================================
Files 11 11
Lines 178 178
=========================================
Hits 137 137
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|