Skip to content

fix(ci): Remove unnecessary permissions and secrets from linter workflow.#35

Merged
terabytesoftw merged 2 commits into
mainfrom
fix_mini_7
Jun 2, 2026
Merged

fix(ci): Remove unnecessary permissions and secrets from linter workflow.#35
terabytesoftw merged 2 commits into
mainfrom
fix_mini_7

Conversation

@terabytesoftw
Copy link
Copy Markdown
Member

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

@terabytesoftw terabytesoftw added the bug Something isn't working label Jun 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 023ae536-d552-455e-b618-281393d1902e

📥 Commits

Reviewing files that changed from the base of the PR and between fef1501 and dcac003.

📒 Files selected for processing (4)
  • .github/workflows/linter.yml
  • CHANGELOG.md
  • tests/timeline/SvgTest.php
  • tests/timeline/TimelinePanelTest.php
💤 Files with no reviewable changes (1)
  • .github/workflows/linter.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: composer-require-checker / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: phpunit / PHP 8.3-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.5-ubuntu-latest
  • GitHub Check: linter / Super Linter
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: phpunit / PHP 8.4-ubuntu-latest
  • GitHub Check: easy-coding-standard / PHP 8.5-ubuntu-latest
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: easy-coding-standard / PHP 8.5-ubuntu-latest
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: phpunit / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.3-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.4-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: phpunit / PHP 8.3-windows-2022
  • GitHub Check: composer-require-checker / PHP 8.5-ubuntu-latest
  • GitHub Check: phpstan / PHP 8.5-ubuntu-latest
  • GitHub Check: linter / Super Linter
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-05-26T15:41:12.893Z
Learnt from: terabytesoftw
Repo: yii2-extensions/debug PR: 32
File: src/views/default/panels/user/summary.php:53-58
Timestamp: 2026-05-26T15:41:12.893Z
Learning: When reviewing Yii2 PHP code that uses `ui-awesome/html-mixin` (e.g., `UIAwesome\Html\Mixin\HasContent`), treat repeated calls to the builder’s `->html(...)` / `->content(...)` as safe accumulation: these methods append content via `.=` concatenation (they do not overwrite previous content) and are variadic. Therefore, multiple calls should not be flagged as an “unintended overwrite” when the code is using `ui-awesome/html-mixin` (as opposed to `ui-awesome/html-concern`, which differs).

Applied to files:

  • tests/timeline/TimelinePanelTest.php
  • tests/timeline/SvgTest.php
🔇 Additional comments (3)
tests/timeline/SvgTest.php (1)

184-184: LGTM!

tests/timeline/TimelinePanelTest.php (1)

605-605: LGTM!

CHANGELOG.md (1)

14-14: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Reduced permissions in the linter CI workflow by removing unnecessary write access and authentication token passing to improve security and streamline configuration.

Walkthrough

This PR applies focused security and maintenance improvements: the GitHub Actions linter workflow reduces permissions and removes redundant secrets passing, a changelog entry documents the CI fix, and two test updates improve fixture clarity and type documentation precision.

Changes

Maintenance and Security Improvements

Layer / File(s) Summary
Workflow permissions and secrets hardening
.github/workflows/linter.yml, CHANGELOG.md
Workflow-level permissions reduced to only contents: read, removing unnecessary checks and statuses write access. Job configuration removes secrets.AUTH_TOKEN passing to the reused workflow. Changelog entry documents the CI fix.
Test fixture and type annotation refinements
tests/timeline/SvgTest.php, tests/timeline/TimelinePanelTest.php
Test fixture in SvgTest simplified to use empty array for panel data without messages key. Test helper docblock type in TimelinePanelTest narrowed from generic keyed array to structured optional-key shape with optional memory, time, and messages keys.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A workflow grows lean, permissions refined,
Secrets removed, security on mind.
Tests speak clearer, fixtures now bright,
Type hints shine true—maintenance done right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unnecessary permissions and secrets from the linter workflow configuration.
Description check ✅ Passed The description relates to the changeset by identifying the PR as a CI/build configuration change, which aligns with the workflow modifications made.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_mini_7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (21ac07e) to head (dcac003).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #35   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2121      2121           
===========================================
  Files            168       168           
  Lines           8598      8598           
===========================================
  Hits            8598      8598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terabytesoftw terabytesoftw merged commit 2fc55a5 into main Jun 2, 2026
29 checks passed
@terabytesoftw terabytesoftw deleted the fix_mini_7 branch June 2, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant