change to imports for pandas Timestamp module#643
change to imports for pandas Timestamp module#643panzerstadt wants to merge 1 commit intoyhat:masterfrom
Conversation
pandas 0.23.0 ggplot 0.11.5 changed `from pandas.lib import Timestamp` to `from pandas import Timestamp`, might break compability with old pandas. an alternative may be to do a try except....? which might look pretty bad, but I haven't really researched into how to support multiple pandas versions with different import endpoints. reference: https://stackoverflow.com/questions/50591982/importerror-cannot-import-name-timestamp
|
Anyway this could be merged @glamp? |
|
The deprecation message is not great advice, the public interface is pandas.Timstamp so this PR is doing the right thing. I've tested it against 0.19.0 as well and the import works fine as per this patch Note, there's a second deprecation message that comes from running gglplot's This is from line 14. It hasn't been removed from Pandas yet but will cause a similar issue that this PR addresses. |
|
Please merge this to align with recent panda changes. |
|
Please merge this -- I am unable to use |
|
Can we please merge this? |
pandas 0.23.0
ggplot 0.11.5
changed
from pandas.lib import Timestamptofrom pandas import Timestamp, might break compability with old pandas.an alternative may be to do a try except....? which might look pretty bad, but I haven't really researched into how to support multiple pandas versions with different import endpoints.
reference: https://stackoverflow.com/questions/50591982/importerror-cannot-import-name-timestamp