postgresql: Add foreign key constraints the first time when migrating #1614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure there isn't an issue for this already, which is a bit surprising! But in postgresql, when you add a foreign key column to an existing table, you need to generate migrations twice to get it fully set up: the first run only creates the column, and the second creates the FK constraint.
This PR adds a test demonstrating the issue as well as removing a guard which I'm reasonably confident isn't necessary (see #1169 (comment)). The commit titled "refactor: don't match on all of the Column fields" also does a refactor to avoid matching on each of the fields of the
Columnvalues, so that it's obvious which values come from the old vs new column, since I found it quite hard to get my head around what this function was doing to start with, but I'm happy to revert that one if you don't think it's an improvement. I recommend reviewing that commit separately from the others.After submitting your PR:
(unreleased)on the Changelog