ci: markers check reports on merge_group (unblock the queue) [bump:patch]#19
Merged
Merged
Conversation
…ump:patch] A required 'markers' check + merge queue deadlocks: the queue fires merge_group and waits for required checks to report there, but the check only triggered on pull_request. Add the merge_group trigger; the validate step stays gated to pull_request (markers are already enforced at PR open), so on merge_group the job runs and reports green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
julian-goldstein
removed this pull request from the merge queue due to a manual request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the merge-queue deadlock: a required
markerscheck + merge queue blocks forever because the queue firesmerge_groupand waits for the check to report there, butcommit-convention.ymlonly triggered onpull_request.Adds the
merge_grouptrigger; the validate step stays gated topull_request(markers are enforced at PR open), so onmerge_groupthe job runs and reports green — letting the queue land.This PR is itself caught by the deadlock — merge it with
gh pr merge <n> --admin --squashonce (after #18). After it's on master, the queue works withmarkersrequired, no more--adminneeded.