Conversation
* chore: partial migration feature * feat: cleanup * feat: adjust location of text * chore: rebase fixes * chore: cleanup on aisle 3 * feat: refine selection for user * chore: rename hooks to clarify use * chore: remove allocator suggestions, filter low yield
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
murderteeth
left a comment
There was a problem hiding this comment.
from telegram
i like where the split option sits in the flow. feels like a tooltip makes sense on hover "Optionally earn your yield in:"
also when i select ETH or BTC, it forces the deposit token select to vbUSDC and disables the selector. maybe intentional? i'll add notes to the pr
There was a problem hiding this comment.
also regarding copy
"Optionally earn your yield in:" -- Gets the job done. But it reads a bit awkward to me. The goal of the text here is to label the split setting. It's also not nessesary to point out that its optional as long as the default state is neither selected and the feature itself is a secondary part of the flow. Makes sense to clarify its optional in the tooltip tho.
For me, "Auto-convert yield to" is more concise and explains the feature clearly.

Explore ways yield splitter can be incorporated into yearn.fi app without bloat / complicating ux.