Skip to content

chore: collapsed transaction info #998#1058

Open
0xeye wants to merge 5 commits intomainfrom
feat/issue-fixes
Open

chore: collapsed transaction info #998#1058
0xeye wants to merge 5 commits intomainfrom
feat/issue-fixes

Conversation

@0xeye
Copy link
Copy Markdown
Collaborator

@0xeye 0xeye commented Feb 9, 2026

#998

x x
Screenshot 2026-02-09 at 19 53 05 Screenshot 2026-02-09 at 19 53 09

Changes:

  • collapsed state for deposit info
  • hide vault share info when 0, to stop 0 = 0 state
  • hide usd on 0
  • adjust text to match Withdraw section, lower case text, upper case start.

@0xeye 0xeye requested a review from rossgalloway February 9, 2026 20:00
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 9, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
yearnfi Ready Ready Preview, Comment Mar 3, 2026 3:18pm

Request Review

@rossgalloway
Copy link
Copy Markdown
Collaborator

I think I may have led us astray in my comment in #998 where we are now in an uncomfortable middle ground. Probably better to show a single line, like you mentioned initially in the issue, and allow expand to show all, or just show all. Now we are in a weird situation where we show a bit and hide a bit.

@0xeye
Copy link
Copy Markdown
Collaborator Author

0xeye commented Feb 10, 2026

I think I may have led us astray in my comment in #998 where we are now in an uncomfortable middle ground. Probably better to show a single line, like you mentioned initially in the issue, and allow expand to show all, or just show all. Now we are in a weird situation where we show a bit and hide a bit.

Good point, I've updated it. Let me know what you think

@rossgalloway
Copy link
Copy Markdown
Collaborator

Good point, I've updated it. Let me know what you think

yep better. You will also need to revert the compressed state for that component that I created when the page gets short. There is one condition where the info section gets collapsed that we don't need with this change. see it by adding dev tools at the bottom of the browser.
image

I'd also say that this is something we should do some user testing around. Can we leave both options in? or have a branch that persists with both options?

@0xeye 0xeye force-pushed the feat/issue-fixes branch from 60a91ff to 0c7e8a1 Compare March 3, 2026 15:17
@0xeye 0xeye changed the title chore: issue fixes #1048 #998 chore: collapsed transaction info #998 Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants