refactor: move calldata decoder from timelock/ to utils/calldata/#201
Merged
refactor: move calldata decoder from timelock/ to utils/calldata/#201
Conversation
Fix inverted dependency where utils/ imported from timelock/. The calldata decoder and known_selectors are shared utilities used by utils/proxy.py and utils/llm/ai_explainer.py, so they belong in utils/. Also moves compound/test_tally.py to tests/ for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timelock/calldata_decoder.pyandtimelock/known_selectors.pytoutils/calldata/to fix inverted dependency (utils/ was importing from a protocol directory)compound/test_tally.pytotests/for consistency with test directory conventionTest plan
uv run ruff check .passesuv run ruff format --check .passesuv run pytest tests/— 98 passed (1 pre-existing telegram topic test failure)from timelock.calldata_decoderorfrom timelock.known_selectorsimports🤖 Generated with Claude Code