Refine workload vector init
#30218
Refine workload vector init
#30218
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring table partitioning options when initializing tables using the workload vector init command. The changes refactor the configuration structure to use dedicated option structs and expose partitioning settings to users.
- Refactored configuration to use
TTableOpts,TTablePartitioningOpts, andTVectorOptsstructs - Added command-line options for controlling table partitioning behavior (min partitions, partition size, auto-partitioning by size/load)
- Updated DDL generation to include user-specified partitioning settings
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ydb/library/workload/vector/vector_workload_params.h | Reorganized member variables to use new structured option types (TTableOpts, TTablePartitioningOpts, TVectorOpts) |
| ydb/library/workload/vector/vector_workload_params.cpp | Replaced manual init parameter configuration with calls to new Configure*Opts functions; updated all references from TableName to TableOpts.Name |
| ydb/library/workload/vector/configure_opts.h | Defined new structs for table options and partitioning options with default values |
| ydb/library/workload/vector/configure_opts.cpp | Implemented configuration functions for table and partitioning options with command-line parameter definitions |
| ydb/library/workload/vector/vector_workload_generator.cpp | Updated DDL query generation to dynamically include partitioning settings based on user configuration |
| ydb/library/workload/vector/vector_sql.cpp | Updated table reference from TableName to TableOpts.Name |
| ydb/library/workload/vector/vector_sampler.cpp | Updated table references from TableName to TableOpts.Name |
| ydb/library/workload/vector/vector_recall_evaluator.cpp | Updated table reference from TableName to TableOpts.Name |
| ydb/library/workload/vector/vector_data_generator.cpp | Updated all table name references from TableName to TableOpts.Name |
| ydb/library/workload/vector/vector_command_index.cpp | Updated table name references from TableName to TableOpts.Name |
| ydb/apps/ydb/CHANGELOG.md | Added changelog entry documenting the new partitioning settings support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
stebloev
changed the title
workload vector initworkload vector init
BackportTo backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.
|
3 participants
Refined
workload vector initMinor changes and now
workload vector initspecifies partition settings for data tableChangelog category
Description for reviewers
...