update offset bugfix #1968
Open
update offset bugfix #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summaryInferred base version: v3.121.0 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 73.92% 73.91% -0.02%
==========================================
Files 394 395 +1
Lines 34454 34498 +44
==========================================
+ Hits 25471 25500 +29
- Misses 7855 7866 +11
- Partials 1128 1132 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Optimize buildPartitionOffsetsMap: use sessionInfo map for O(1) lookup instead of O(n*m) search - Refactor tests: add helper methods, remove duplication, improve structure - Remove Given-When-Then comments as requested - Fix linter issues: line length, return statements, formatting
🌋 SLO Test ResultsStatus: 🟡 6 workloads tested • 3 workloads with warnings
Generated by ydb-slo-action |
rekby
reviewed
Dec 8, 2025
|
|
||
| req := r.createUpdateOffsetRequest(ctx, batch, tx) | ||
| updateOffsetInTransactionErr := retry.Retry(ctx, func(ctx context.Context) (err error) { | ||
| if r.batchTxStorage.Add(tx, batch) { |
|
|
||
| tx.OnBeforeCommit(r.txBeforeCommitFn(tx)) | ||
|
|
||
| tx.OnCompleted(func(err error) { |
Member
There was a problem hiding this comment.
Получится тоже вынести в отдельный метод?
| po := &partitionOffsets[i] | ||
| info, ok := sessionInfoMap[po.PartitionSessionID] | ||
| if !ok { | ||
| // Skip if session info not found (should not happen in normal flow) |
Member
There was a problem hiding this comment.
Вот тут тогда надо кидать ошибку, чтобы не скрывать внутренние ошибки если они появятся.
пропущенный коммит отлаживать будет заметно сложнее, чем явную ошибку.
| ) | ||
|
|
||
| type BatchTxStorageTestSuite struct { | ||
| suite.Suite |
Member
There was a problem hiding this comment.
Нужны ли тут suite? этот способ запуска тестов новый для go sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information