Skip to content

Add integration tests for Decimal scanning in query and database/sql clients #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add integration tests for Decimal scanning in query and database/sql clients #1938

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ee77ce
Initial plan
Copilot Nov 17, 2025
5eb7e83
Add comprehensive integration tests for decimal scanning support
Copilot Nov 17, 2025
8913dba
Merge branch 'master' into copilot/add-ydb-decimal-support
asmyasnikov Nov 27, 2025
ff48ef9
Merge branch 'master' into copilot/add-ydb-decimal-support
asmyasnikov Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
262 changes: 262 additions & 0 deletions tests/integration/decimal_scan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,262 @@
//go:build integration
// +build integration

package integration

import (
"context"
"database/sql"
"math/big"
"os"
"testing"

"github.com/stretchr/testify/require"

"github.com/ydb-platform/ydb-go-sdk/v3"
"github.com/ydb-platform/ydb-go-sdk/v3/pkg/xtest"
"github.com/ydb-platform/ydb-go-sdk/v3/query"
"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
)

// TestQueryDecimalScan tests scanning decimal values using query client with direct Scan method
func TestQueryDecimalScan(t *testing.T) {
ctx, cancel := context.WithCancel(xtest.Context(t))
defer cancel()

db, err := ydb.Open(ctx,
os.Getenv("YDB_CONNECTION_STRING"),
ydb.WithAccessTokenCredentials(os.Getenv("YDB_ACCESS_TOKEN_CREDENTIALS")),
)
require.NoError(t, err)
defer func() {
_ = db.Close(ctx)
}()

t.Run("DirectScan", func(t *testing.T) {
// Test scanning decimal using direct Scan method
row, err := db.Query().QueryRow(ctx,
`SELECT Decimal('123456789.987654321', 33, 12)`,
query.WithIdempotent(),
)
require.NoError(t, err)

var dst types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)

// Verify precision and scale
require.Equal(t, uint32(33), dst.Precision)
require.Equal(t, uint32(12), dst.Scale)

// Verify the value
expectedBigInt := big.NewInt(123456789987654321)
actualBigInt := dst.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)

// Verify String representation
require.Equal(t, "123456789.987654321", dst.String())
})

t.Run("DirectScanNegative", func(t *testing.T) {
// Test scanning negative decimal
row, err := db.Query().QueryRow(ctx,
`SELECT Decimal('-5.33', 22, 9)`,
query.WithIdempotent(),
)
require.NoError(t, err)

var dst types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)

// Verify precision and scale
require.Equal(t, uint32(22), dst.Precision)
require.Equal(t, uint32(9), dst.Scale)

// Verify the value
expectedBigInt := big.NewInt(-5330000000)
actualBigInt := dst.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)
})

t.Run("DirectScanWithOtherTypes", func(t *testing.T) {
// Test scanning decimal along with other types
row, err := db.Query().QueryRow(ctx,
`SELECT 42u AS id, Decimal('10.01', 22, 9) AS amount`,
query.WithIdempotent(),
)
require.NoError(t, err)

var id uint64
var amount types.Decimal
err = row.Scan(&id, &amount)
require.NoError(t, err)

require.Equal(t, uint64(42), id)
require.Equal(t, uint32(22), amount.Precision)
require.Equal(t, uint32(9), amount.Scale)

expectedBigInt := big.NewInt(10010000000)
actualBigInt := amount.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)
})

t.Run("DirectScanOptional", func(t *testing.T) {
// Test scanning optional decimal (NULL)
row, err := db.Query().QueryRow(ctx,
`SELECT CAST(NULL AS Decimal(22, 9))`,
query.WithIdempotent(),
)
require.NoError(t, err)

var dst *types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)
require.Nil(t, dst)
})

t.Run("DirectScanOptionalNonNull", func(t *testing.T) {
// Test scanning optional decimal (non-NULL)
row, err := db.Query().QueryRow(ctx,
`SELECT JUST(Decimal('99.99', 22, 9))`,
query.WithIdempotent(),
)
require.NoError(t, err)

var dst *types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)
require.NotNil(t, dst)
require.Equal(t, uint32(22), dst.Precision)
require.Equal(t, uint32(9), dst.Scale)

expectedBigInt := big.NewInt(99990000000)
actualBigInt := dst.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)
})
}

// TestDatabaseSqlDecimalScan tests scanning decimal values using database/sql
func TestDatabaseSqlDecimalScan(t *testing.T) {
ctx, cancel := context.WithCancel(xtest.Context(t))
defer cancel()

nativeDriver, err := ydb.Open(ctx,
os.Getenv("YDB_CONNECTION_STRING"),
ydb.WithAccessTokenCredentials(os.Getenv("YDB_ACCESS_TOKEN_CREDENTIALS")),
)
require.NoError(t, err)
defer func() {
_ = nativeDriver.Close(ctx)
}()

// Test both with table service (WithQueryService(false)) and query service (WithQueryService(true))
for _, tt := range []struct {
name string
queryService bool
}{
{
name: "TableService",
queryService: false,
},
{
name: "QueryService",
queryService: true,
},
} {
t.Run(tt.name, func(t *testing.T) {
connector, err := ydb.Connector(nativeDriver,
ydb.WithQueryService(tt.queryService),
)
require.NoError(t, err)
defer func() {
_ = connector.Close()
}()

db := sql.OpenDB(connector)

t.Run("DirectScan", func(t *testing.T) {
// Test scanning decimal using direct Scan method
row := db.QueryRowContext(ctx, `SELECT Decimal('123456789.987654321', 33, 12)`)

var dst types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)

// Verify precision and scale
require.Equal(t, uint32(33), dst.Precision)
require.Equal(t, uint32(12), dst.Scale)

// Verify the value
expectedBigInt := big.NewInt(123456789987654321)
actualBigInt := dst.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)

// Verify String representation
require.Equal(t, "123456789.987654321", dst.String())
})

t.Run("DirectScanNegative", func(t *testing.T) {
// Test scanning negative decimal
row := db.QueryRowContext(ctx, `SELECT Decimal('-5.33', 22, 9)`)

var dst types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)

// Verify precision and scale
require.Equal(t, uint32(22), dst.Precision)
require.Equal(t, uint32(9), dst.Scale)

// Verify the value
expectedBigInt := big.NewInt(-5330000000)
actualBigInt := dst.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)
})

t.Run("DirectScanWithOtherTypes", func(t *testing.T) {
// Test scanning decimal along with other types
row := db.QueryRowContext(ctx, `SELECT 42u AS id, Decimal('10.01', 22, 9) AS amount`)

var id uint64
var amount types.Decimal
err = row.Scan(&id, &amount)
require.NoError(t, err)

require.Equal(t, uint64(42), id)
require.Equal(t, uint32(22), amount.Precision)
require.Equal(t, uint32(9), amount.Scale)

expectedBigInt := big.NewInt(10010000000)
actualBigInt := amount.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)
})

t.Run("DirectScanOptional", func(t *testing.T) {
// Test scanning optional decimal (NULL)
row := db.QueryRowContext(ctx, `SELECT CAST(NULL AS Decimal(22, 9))`)

var dst *types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)
require.Nil(t, dst)
})

t.Run("DirectScanOptionalNonNull", func(t *testing.T) {
// Test scanning optional decimal (non-NULL)
row := db.QueryRowContext(ctx, `SELECT JUST(Decimal('99.99', 22, 9))`)

var dst *types.Decimal
err = row.Scan(&dst)
require.NoError(t, err)
require.NotNil(t, dst)
require.Equal(t, uint32(22), dst.Precision)
require.Equal(t, uint32(9), dst.Scale)

expectedBigInt := big.NewInt(99990000000)
actualBigInt := dst.BigInt()
require.Equal(t, expectedBigInt, actualBigInt)
})
})
}
}
Loading